casa / casa6 / 4c55227f00c

Commits

Federico Montesino Pouzols authored 4c55227f00c 20 Jan 2025

update and extend tests for output center values in same frame as metadata, CAS-13616

casatasks/tests/tasks/test_task_phaseshift.py

Modified

-95
+        Ensures that the field subtable of outputvis has the expected phase centers
-96
+        (from 'new_centers' passed to the phasecenter parameter of phaseshift),
-97
+        comparing also unmodified ('passthrough') fields with the 'inputvis'.
-98
-99
+        :param outputvis: output, phase-shifted MS to check
-100
+        :param inputvis: input MS, to compare against when some fields unchanged
-101
+        :param new_centers: string or dict with new phase center(s)
-102
+        :param field_selection: field selected as integer if used (only single value supported)
-103
-104
+        """
--
+        from casatasks.private.task_phaseshift import _convert_to_ra_dec_j2000
-+
+        from casatasks.private.task_phaseshift import (_find_field_ref_frames,
-+
+                                                       _convert_to_ref_frame)
-107
-108
+        def get_expected_output_ra_dec(row, new_centers, input_phase_col,
--
+                                       field_selection):
-+
+                                       field_selection, field_frames):
-110
+            field_id = str(row)
-111
+            if isinstance(new_centers, dict):
-112
+                if field_id in new_centers:
--
+                    ra_rad, dec_rad = _convert_to_ra_dec_j2000(
--
+                        new_centers[field_id])
-+
+                    ra_rad, dec_rad = _convert_to_ref_frame(new_centers[field_id],
-+
+                                                            field_frames[row])
-115
+                else:
-116
+                    ra_rad = input_phase_col[0, 0, row]
-117
+                    dec_rad = input_phase_col[1, 0, row]
-118
+            else:
-119
+                if field_selection and row != field_selection:
-120
+                    ra_rad = input_phase_col[0, 0, row]
-121
+                    dec_rad = input_phase_col[1, 0, row]
-122
+                else:
--
+                    ra_rad, dec_rad = _convert_to_ra_dec_j2000(new_centers)
-+
+                    ra_rad, dec_rad = _convert_to_ref_frame(new_centers, field_frames[row])
-124
-125
+            return ra_rad, dec_rad
-126
-127
+        def get_field_subt_phasedir_col(vis_path):
-128
+            try:
-129
+                tblocal = table()
-130
+                tblocal.open(vis_path + '/FIELD', nomodify=True)
-131
+                phase_col = tblocal.getcol('PHASE_DIR')
-132
+            finally:
-133
+                tblocal.done()
-134
-135
+            return phase_col
-136
-+
+        def get_field_frame_names(vis_path):
-+
+            try:
-+
+                tblocal = table()
-+
+                tblocal.open(vis_path + '/FIELD', nomodify=True)
-+
+                field_frames = _find_field_ref_frames(tblocal)
-+
+            finally:
-+
+                tblocal.done()
-+
-+
+            return field_frames
-146
-147
+        phase_col = get_field_subt_phasedir_col(outputvis)
-148
+        input_phase_col = get_field_subt_phasedir_col(inputvis)
-+
+        # Get as reference the ref frames of the input vis (with mstransform we expect the output MS
-+
+        # should have the same metadata = same frames as the input MS)
-+
+        field_frames = get_field_frame_names(inputvis)
-+
-153
+        for row in range(0, phase_col.shape[-1]):
-154
+            ra_rad, dec_rad = get_expected_output_ra_dec(row, new_centers,
-155
+                                                         input_phase_col,
--
+                                                         field_selection)
-+
+                                                         field_selection,
-+
+                                                         field_frames)
-158
-159
+            # The 0 in the middle is the 'NUM_POLY' axis
-160
+            self.assertEqual(phase_col[0, 0, row], ra_rad,
-161
+                             f"unexpected PHASE_DIR ra value in row {row} "
-162
+                             f"(with {new_centers=})")
-163
+            self.assertEqual(phase_col[1, 0, row], dec_rad,
-164
+                             f"unexpected PHASE_DIR dec value in row {row} "
-165
+                             f"(with {new_centers=})")
-166
-167
-1035
+            self.assertTrue(
-1036
+                x['max'][0]/x['rms'][0] < 5,
-1037
+                msg='Incorrectly found signal in empty field, got S/N of '
-1038
+                + str(x['max'][0]/x['rms'][0])
-1039
+            )
-1040
+            self.__delete_intermediate_products()
-1041
-1042
-1043
+class phaseshift_subfunctions_test(unittest.TestCase):
-1044
--
+    def test__convert_to_j2000(self):
--
+        from casatasks.private.task_phaseshift import _convert_to_ra_dec_j2000
-+
+    def setUp(self):
-+
+        shutil.copytree(datapath, datacopy)
-+
+        shutil.copytree(datapath_ngc, datacopy_ngc)
-+
+        change_perms(datacopy)
-+
+        change_perms(datacopy_ngc)
-+
-+
+    def tearDown(self):
-+
+        shutil.rmtree(datacopy)
-+
+        shutil.rmtree(datacopy_ngc)
-+
-+
+    def test__fiend_field_ref_frame(self):
-+
+        from casatasks.private.task_phaseshift import _find_field_ref_frames
-+
-+
+        try:
-+
+            tblocal = table()
-+
+            tblocal.open(datacopy + "/FIELD", nomodify=True)
-+
+            ref_frames = _find_field_ref_frames(tblocal)
-+
+        finally:
-+
+            tblocal.close()
-+
-+
+        self.assertEqual(ref_frames, {0: "J2000"})
-+
-+
+    def test__fiend_field_ref_frame_b1950_vla(self):
-+
+        from casatasks.private.task_phaseshift import _find_field_ref_frames
-+
-+
+        try:
-+
+            tblocal = table()
-+
+            tblocal.open(datacopy_ngc + "/FIELD", nomodify=True)
-+
+            ref_frames = _find_field_ref_frames(tblocal)
-+
+        finally:
-+
+            tblocal.close()
-+
-+
+        self.assertEqual(ref_frames, {0: "B1950_VLA", 1: 'B1950_VLA', 2: 'B1950_VLA'})
-+
-+
+    def test__convert_to_ref_frame(self):
-+
+        from casatasks.private.task_phaseshift import _convert_to_ref_frame
-1081
-1082
+        phasecenter = 'J2000 19h53m50 40d06m00'
--
+        fra, fdec = _convert_to_ra_dec_j2000(phasecenter)
-+
+        fra, fdec = _convert_to_ref_frame(phasecenter, "J2000")
-1084
+        places = 6
-1085
+        self.assertAlmostEqual(fra, -1.074105, places=places)
-1086
+        self.assertAlmostEqual(fdec, 0.6998770, places=places)
-1087
--
+    def test__convert_to_j2000_using_default_frame(self):
--
+        from casatasks.private.task_phaseshift import _convert_to_ra_dec_j2000
-+
+    def test__convert_to_ref_frame_using_default_frame(self):
-+
+        from casatasks.private.task_phaseshift import _convert_to_ref_frame
-1090
-1091
+        phasecenter = '19h53m50 40d06m00'
--
+        fra, fdec = _convert_to_ra_dec_j2000(phasecenter)
-+
+        fra, fdec = _convert_to_ref_frame(phasecenter, "J2000")
-1093
+        places = 6
-1094
+        self.assertAlmostEqual(fra, -1.074105, places=places)
-1095
+        self.assertAlmostEqual(fdec, 0.6998770, places=places)
-1096
--
+    def test__convert_to_j2000_wrong(self):
--
+        from casatasks.private.task_phaseshift import _convert_to_ra_dec_j2000
-+
+    def test__convert_to_ref_frame_wrong(self):
-+
+        from casatasks.private.task_phaseshift import _convert_to_ref_frame
-1099
-1100
+        phasecenter = 'BOGUS xxh53m50 40d06m00'
-1101
+        with self.assertRaisesRegex(RuntimeError, expected_regex="failed"):
--
+            fra, fdec = _convert_to_ra_dec_j2000(phasecenter)
-+
+            fra, fdec = _convert_to_ref_frame(phasecenter, "B1950_VLA")
-+
-+
+    def test__convert_to_ref_frame_icrs(self):
-+
+        from casatasks.private.task_phaseshift import _convert_to_ref_frame
-+
-+
+        phasecenter = 'B1950 19h53m50 40d06m00'
-+
+        fra, fdec = _convert_to_ref_frame(phasecenter, "ICRS")
-+
+        places = 6
-+
+        self.assertAlmostEqual(fra, -1.066522, places=places)
-+
+        self.assertAlmostEqual(fdec, 0.7022094, places=places)
-1112
-1113
-1114
+class phaseshift_multi_phasecenter_test(phaseshift_base_checks):
-1115
+    """ Tests around the use of multi-field phasecenter values (dicts) """
-1116
-1117
+    # Other candidates, could have been:
-1118
+    # uid___A002_X30a93d_X43e_small.ms: 3 fields, but only 3 scans, and >240MB
-1119
+    # uid___X02_X3d737_X1_01_small.ms: 3 fields, but only 3 scans
-1120
+    # twocenteredpointsources.ms: simulated, 2 fields, only 2 scans, (fixvis)
-1121
+    datadir_multifield = os.path.join('measurementset', 'alma')
-1209
+    def test_test_nodict(self):
-1210
+        new_center = 'J2000 19h53m50 40d06m00'
-1211
+        result = phaseshift(datacopy, outputvis=self.outputvis,
-1212
+                            phasecenter=new_center)
-1213
-1214
+        self.check_nrows(self.outputvis, 15344)
-1215
+        self.check_field_subtable(self.outputvis, datacopy, new_center)
-1216
-1217
+    def test_phasecenter_dict_one_out(self):
-1218
+        ''' Check multiple field phasecenter(s) given as a dict, skip one field '''
--
+        new_centerA = 'J2000 19h53m50 40d06m00'
--
+        new_centerB = 'J2000 22h01m02 40d04m03'
-+
+        new_centerA = 'GALACTIC 19h53m50 40d06m00'
-+
+        new_centerB = 'GALACTIC 22h01m02 40d04m03'
-1221
+        phasecenter = {'0': new_centerA,
-1222
+                       '2' : new_centerB}
-1223
+        result = phaseshift(datacopy, outputvis=self.outputvis,
-1224
+                            phasecenter=phasecenter)
-1225
-1226
+        self.assertEqual(result, None)
-1227
+        self.check_nrows(self.outputvis, 15344)
-1228
+        self.check_field_subtable(self.outputvis, datacopy, phasecenter)
-1229
-1230
+        for ddi in self.relevant_ddis_multifield:
-1231
+            self.check_field_unchanged(datacopy, self.outputvis, ddi=ddi,
-1232
+                                       field='1')
-1233
-1234
+    def test_phasecenter_dict_with_field_selection_overlapping(self):
-1235
+        ''' Check multiple field phasecenter(s) given as a dict,
-1236
+        skip one field, with selection of all fields in phasecenter dict '''
--
+        new_centerA = 'J2000 19h53m50 40d06m00'
--
+        new_centerB = 'J2000 22h01m02 40d04m03'
-+
+        new_centerA = 'ICRS 19h53m50 40d06m00'
-+
+        new_centerB = 'ICRS 22h01m02 40d04m03'
-1239
+        phasecenter = {'0': new_centerA,
-1240
+                       '2' : new_centerB}
-1241
+        result = phaseshift(datacopy, outputvis=self.outputvis, field='0,2',
-1242
+                            phasecenter=phasecenter)
-1243
-1244
+        self.assertEqual(result, None)
-1245
+        self.check_nrows(self.outputvis, 11536)
-1246
+        self.check_field_subtable(self.outputvis, datacopy, phasecenter)
-1247
-1248
+    def test_phasecenter_dict_with_field_selection_nonoverlapping(self):

casa6

Commits

Jira Issues

Add shortcut