Pull request #782: CAS-14235 new WS client task getantposalmaMerge in CASA/casa6 from CAS-14235 to master
* commit '3ca5b63d630430a4c0f97da661ee3e3f6b196db8': (37 commits)
doc corrections requested by akepley
tweak of output data structure
change output struct from list to dict
added "caltype" to metadata
fix up test
add json.loads() to write to a file something easier for gencal to handle. Requested by Enrique.
minor doc updates
new doc...
Pull request #781: CAS-13359Merge in CASA/casa6 from CAS-13359 to master
* commit '5c33a81582dbdaa21dea29ccb23df972dbfae96c':
Now usescratch's default is True in setjy, modified setjy command in test_model_keys to explicitly set usescatch=False
Add a test for the exception handling
Modify to use RuntimeError rather than generic Exception and the boolean comparison to follow PEP8
Minor edit to retrigger build
A ...
Pull request #779: CAS-13544Merge in CASA/casa6 from CAS-13544 to master
* commit '067003ae1f13325b61f64ccbd286adfbf761c9d9':
For CAS-13544, remove CRs in xml text that seem to mess up formatting in casadocs.
For CAS-13544, updated test_task_polfromgain.py to use proper symbolic link to input data in casatestdata (checked in by scastro this date); cleaned up polfromgain.xml to match corresponding changes in casadocs....
Pull request #777: CAS-14266Merge in CASA/casa6 from CAS-14266 to master
* commit '35aa5b675a4d465b976538cdcd112c1f70eb3772':
CAS-14266 do not initialize UVWMachine for single-dish imaging
Pull request #775: Update Casacore to f1c629840eMerge in CASA/casa6 from CAS-14274 to master
* commit '0ea19da0cbb2b20ba84125a4a91978e020429fdc':
Update Casacore to f1c629840e
CAS-14184 : Fix test to account for previous changeThe "test_mask_preserve_input_zero_mask" test in test_task_deconvolve
was failing because of the wrong stopcode. As of the previous commit the
stopcode is now over-written by the niter=0 dict, rather than what is
written by the C++ code. This has no operation impact apart from the
specific niter=0 case, and the stopcode for this test had to be changed
to reflect that.
CAS-14184 : Fix to deconvolve return dictThe task_deconvolve return dictionary did not contain "stopDescription"
for the niter=0 case. This commit fixes that issue.
CAS-14184 : Fixes to gclean tests + masking bugfixIf a static user mask was provided in the input (e.g.,
circle[[50px,50px],10px]) the final mask-update deconvolve step was
breaking. It did not break for auto-masking or any other type of input
mask. This has been fixed by setting mask = '' in the last deconvolve
call, which still does the right thing for auto-masking etc.
Further, the default masking behaviour changed as of a few commits ago....
Renamed test_task_gclean to test_imagerhelpers_gclean and moved it to the scripts directory.Added the new test script to the mapping json file to run automatically in Bamboo.
Pull request #774: CAS-13714Merge in CASA/casa6 from CAS-13714 to master
* commit '9bd7a74d61dfcdb3638178e26880df518f04c9be':
This commit is unrelated to the changes on this branch. They are changes needed for the verification tests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again some of the entries in the json file that were out of place.
Removed unused function prepinputmask....
CAS-14184 : Fix for history loggingIf convergence was hit, the logger would repeatedly print out it's entire
history to the log. Issued a fix to account for that.
CAS-14184 : Fix mask handling logic on startupThe mask handling used to be in the frontend, but moved it to the
backend. It now correctly accounts for a restarted state with a
previously active mask.
The logic is :
- Initial launch : If usemask='user' and mask = '' then make sure the
default mask is filled with zeros before the GUI is launched. Leave mask
untouched for all other cases
- Restart :
- If usemask='user' and mask='' :
...
CAS-14184 : Fixed masking paramsSome auto-multithresh parameters were missing from the _gclean input,
added those in.
The order of masking was also incorrect, the auto-mask growing was
happening _prior_ to deconvolution rather than after. This has also been
fixed.
CAS-14184 : Add check for user updated maskThe user can update/change the mask in between major cycles. Previously
gclean was invoking `deconvolve` to do this, but now there is an
additional function that uses `imstat` to check if the peakresidual has
changed because of a mask update in between major cycles.
This has implications on whether to continue deconvolution or not, and
therefore needs to be done before deconvolve is called.
CAS-14184 : Fix peakres calculationAdded a check for masksum while calculating peakres across a cube. Only
in the case that masksum > 0 is peakres considered now.
This prevents the "bouncing" behaviour reported by Josh described below:
Iteration 1 :
field 0, chan 0, stokes 0, peakres [1.0149141550064087]
field 0, chan 1, stokes 0, peakres [5.736467361450195]
field 0, chan 2, stokes 0, peakres [4.154384136199951]
cyclethreshol...
CAS-14184 : Bugfix for niter=0 peakres calculationIf no mask was passed in for the niter=0 case, the `ImagingDict`
class set the `mask` parameter to -1 (instead of the pixel mask).
peakRes was always calcualted as `np.amax(image_pixels * mask_pixels)`
so when mask = -1 it picked the highest negative as the peakRes.
This commit fixes that bug, and has been confirmed to pass the
previously failing task_tclean tests.
Additionally, removed a che...
This commit is unrelated to the changes on this branch. They are changes needed for the verificationtests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again
some of the entries in the json file that were out of place.
Ville Suoranta
