Sanjay Bhatnagar 19824e36c16 M Merge branch 'ARD-16' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-16 15 Apr 2019 ARD-16 Sanjay Bhatnagar d0403922a26 PhaseGrad: Factored out needsNewPhaseGrad() into a function and using
it in this class and VB2CFBMap.
VB2CFBMap: Computing phase grad for row 0 only when
PhaseGrad::needsNewPhaseGrad() returns true. PhaseGrad: Factored out needsNewPhaseGrad() into a function and using it in this class and VB2CFBMap.
VB2CFBMap: Computing phase grad for row 0 only when
PhaseGrad::needsNewPhaseGrad() returns true. 15 Apr 2019 Preshanth Jagannathan 27204a41df1 Fixed bracket clashes in PhaseGrad 15 Apr 2019 Preshanth Jagannathan 90bc1ab7732 Changes to apply the same PO for every antenna 15 Apr 2019 Preshanth Jagannathan 5ced0a61990 M Merge branch 'ARD-15' into ARD-16 15 Apr 2019 2 Jira issuesPreshanth Jagannathan ab77eee3dab Sign flipped back in Pointing Offsets 12 Apr 2019 Sanjay Bhatnagar 87e5c538912 Print debugging info. from PO::findAntennaPointingOffset() if PO_DEBUG env. variable (or equivalent ~/.casarc variable) is set to 1. 11 Apr 2019 Sanjay Bhatnagar 647b4b0302b AWVR: Cleanup in GridToData. Removed call to getPointingOffsets() and using CFB:finitePointingOffset().
PO.cc: Using dc_p.directionType() in findMosaicPointingOffsets().
Signe flip for gPP in gradPerPixel(). 10 Apr 2019 Preshanth Jagannathan 188b6d6efe6 The primary changes here are in drawing in bugfix/CAS-11191 files msvis/MSVis/VisBufferUtil.{cc,h} and
synthesis/TransformMachines2/SimplePBConvFunc.{cc,h}
to incorporate kumars new changes. In PointingOffsets.cc the call
to vbUtil.getPointingDir has been changed to reflect the dc_p.directionType()
which is the image direction type. 09 Apr 2019 CAS-11191 Sanjay Bhatnagar 7c2bcc84104 AWVR: Code cleanup. CFB is a CountedPtr everywhere now. PO: Make VisBufferUtils a private variable to benefit from it's
internal caching when getting antenna pointing offsets from the
POINTING sub-table. 08 Apr 2019 Sanjay Bhatnagar 6dae7044d0c Enabled commented code in PO.cc that handles frame issues between POINTING table and MS (code from KG)
Moved finitePointingOffsets from AWVR to CFB. Using only in gridding
for now. 07 Apr 2019 Sanjay Bhatnagar f299d6adec3 Commit of pointing-aware and vb-row aware gridder code. The following code in AWVR needs to be considered carefully:
cfb = (*(*vb2CFBMap_p)[irow]);
Change in this or moving this line leads to what looks like corrupted
cfb. That manifested itself as imaging not working for w>1. 05 Apr 2019 Sanjay Bhatnagar b51525613da Set subparam=true for dopointing and conjbeams 01 Apr 2019 Preshanth Jagannathan d57401fb42c Revert "Changes in PhaseGrad.{cc,h} and VB2CFMap.cc." This reverts commit e1a018cfab0b3d46914185eaa649ce30e8f34f9a. 13 Mar 2019 Sanjay Bhatnagar e1a018cfab0 Changes in PhaseGrad.{cc,h} and VB2CFMap.cc. PhaseGrad: cache_FieldGrad_p caches values for each row of the VB. VB2CFMap: Call PhaseGrad::getFieldPointingGrad only if ComputeFieldPointingGrad returns True. The above changes, while make logical sense, don't work properly. The
first gives a strange PB and the latter leads to seg. fault. 09 Mar 2019 Preshanth Jagannathan 6c0e12bea7b Changes to pointing offset to use the both antenna locations in the event that they have different pointing offsets 07 Mar 2019 preshanth jagannadhan ccede4860c8 AWProjectFT and AWProjectWBFT have additions to account for PO vector of vector modifications and VB2CFBMap_p->setDoPointing calls. This call should be dropped when a smart baseline object is put in as a replacement. AWVisResampler is now gridding row aware for the phaseGrad object. The switch
to per row calls for phaseGrad are also inplace in VB2CFBMap, PointingOffsets and PhaseGrad 06 Mar 2019 preshanth jagannadhan 2d082d6f016 This is another large commit with the intention of converting the pointing offset object from a vector of doubles to a vector of vector of doubles. This required template changes to the following code/synthesis/TransformMachines2/ConvolutionFunction.h
code/synthesis/TransformMachines2/IlluminationConvFunc.h
code/synthesis/TransformMachines2/AWConvFunc.h
code/synthesis/TransformMachines2/CFBuffer.h
Changes were also made to code/synthesis/TransformMachines2/CFBuffer.cc
in the class toAsStruct a GPU convolution function generation class.
The remaining changes to code/synthesis/Trans... 05 Mar 2019 preshanth jagannadhan 49a78705242 I had commented out the AWP header by mistake. Oops 28 Feb 2019 preshanth jagannadhan f064b71e3a8 The changes ar emade to ensure that the unit test passes after the depracation of AWConvFuncEPJones in the test. Also AWProjectFT
now requires the initialization of the pointing offset object po_p. 28 Feb 2019 Sanjay Bhatnagar 3db04225b6f Code cleanup. 27 Feb 2019 preshanth jagannadhan 1e90ca769de Changes to eliminate AWConvFuncEPJones.cc and .h from TransformMachines2 Commented out some error checking in code/synthesis/TransformMachines2/PointingOffsets.cc 27 Feb 2019 preshanth jagannadhan 64813ce916a This is a rather large commit with changes to accept dopointing from the user and pass it down to the PointinOffset class either uses the pointing table or ignores it during gridding. The following files were changed to allow the pointing to flow
gcwrap/tasks/tclean.xml
gcwrap/python/scripts/task_tclean.py
code/synthesis/ImagerObjects/SynthesisImagerVi2.cc
The dopointing changes also resulted in the depracation of AWConvFuncEPJones
class and the associated header.
code/synthesis/ImagerObjects/SynthesisImagerVi2.cc
code/synthesis/ImagerObjects/SynthesisImagerVi2.h
code/synth... 27 Feb 2019 CAS-11191 Sanjay Bhatnagar d82ac59076b Enable use of findAntennaPointingOffset in AWCFEPJ to be sensitive to the POINTING sub-table in the MS. Minor changes in AWVR and PhaseGrad.
SynthUtil+tclean.xml: Enable gridder='awp' in the interface. 13 Feb 2019 Sanjay Bhatnagar 0904109d97c M Merge branch 'feature/ARD-15' of https://open-bitbucket.nrao.edu/scm/casa/casa into feature/ARD-15 08 Feb 2019 ARD-15 Sanjay Bhatnagar ed64daceb4e Integrated PhaseGrad and VB2CFBMap objects. Using the latter's interface in AWVR. 08 Feb 2019 preshanth jagannadhan e3f8e51cee2 Move vbRow2CFBMap_p pointer to the more appropriately named vb2CFBMap_p in AWProjectFT.{cc,h} VB2CFBMap.{cc,h}
VisibilityResamplerBase.{cc,h} VisibiltiyResampler.cc AWProjectWBFT.cc 07 Feb 2019 preshanth jagannadhan 0ffa3b9acef Reverted to mosaic pointing offset in AWConvFuncEPJones::findPointingOffset 07 Feb 2019 Sanjay Bhatnagar 269032c0633 M Merge branch 'feature/ARD-15' of https://open-bitbucket.nrao.edu/scm/casa/casa into feature/ARD-15 07 Feb 2019 ARD-15 Sanjay Bhatnagar 02157e28503 Disabling use of POINTING table in AWConvFuncEPJones::findPointingOffset. 07 Feb 2019 preshanth jagannadhan 8e12279022f Revert "Disable tFringeJones_GT" This reverts commit f52d52bdb46400dcb0c6e92d6dad4cdee1035f18. 06 Feb 2019 Sanjay Bhatnagar 3c17ce5232b Mods to remove annoying compiler warnings. 05 Feb 2019 preshanth jagannadhan b6e0d2de864 M Merge branch 'ARD-16' into feature/ARD-15 05 Feb 2019 2 Jira issuespreshanth jagannadhan c844c250d18 Some puzzling local commits 05 Feb 2019 preshanth jagannadhan 2d49831b574 puzzling commit 05 Feb 2019 Sanjay Bhatnagar ab82f4e1f48 Minor changes in VB2CFBMap.{cc,h}. 05 Feb 2019 Sanjay Bhatnagar 075b99b16a8 First checkin of working code using VB2CFMap object. 05 Feb 2019 Sanjay Bhatnagar e15b48a10a3 Intermediate checkin for using VB2CFBMap. 05 Feb 2019 Sanjay Bhatnagar bc96d01fed0 M Merge branch 'feature/ARD-15' of https://open-bitbucket.nrao.edu/scm/casa/casa into feature/ARD-15 05 Feb 2019 ARD-15 Sanjay Bhatnagar d9bc8d5dfd3 AWPCFEPJ: Using PO methods AWP{WB}FT, VRB: Removed CF dependency from makeVB2RowCFBMap
PO: Added method to read POINTING table. 05 Feb 2019 Preshanth Jagannathan 506abf3ee01 VB2CFMap class defined and changes made across the following locations 05 Feb 2019 Preshanth Jagannathan 2c4204dcc44 M Merge branch 'feature/ARD-16' into ARD-16 Conflicts:
casacore 05 Feb 2019 ARD-16 preshanth jagannadhan 2ee4943ea78 Revert "VB2CFBMap changes" This reverts commit 1419480fd6f99544e7e47a77caf59a21c1b6f3dc. 04 Feb 2019 preshanth jagannadhan 1419480fd6f VB2CFBMap changes 04 Feb 2019 Sanjay Bhatnagar cdbb2fad0f5 Some refactoring in PointingOffsets class to use POINTING table. The latter is not yet in use. 01 Feb 2019 Ville Suoranta f52d52bdb46 Disable tFringeJones_GT 01 Feb 2019 Ville Suoranta 8baa7e0646d M Merge pull request #855 in CASA/casa from bugfix/CAS-12239 to master * commit 'b4a03a95170904763389820473e06c2a7d475b30':
Updated the unitTests to prior values (also correct the ones) for awp and wbawp refimager 01 Feb 2019 CAS-12239 Ville Suoranta a383ac5a200 Revert "Merge pull request #853 in CASA/casa from CAS-12238 to master" This reverts commit ab3d933855ef8dc1b2f6ffd27b38a26a1eb8eb08, reversing
changes made to 2f8b67389ff5ecee263e1d591d405e293878074c. 31 Jan 2019 CAS-12238 preshanth jagannadhan b4a03a95170 Updated the unitTests to prior values (also correct the ones) for awp and wbawp refimager 31 Jan 2019 Ville Suoranta ab3d933855e M Merge pull request #853 in CASA/casa from CAS-12238 to master * commit 'a3400647a1dcc59f2bd9281e6b50465056c1c910':
CAS-12238 squash compiler warnings 31 Jan 2019 CAS-12238