casa / casa6 / 4a3f501ed6e

Commits

Federico Montesino Pouzols authored 4a3f501ed6e 28 Jul 2020

consistent error (except) handling, task sdpolaverage ->CASA6, CAS-13125, CAS-13018

casatasks/src/tasks/task_sdpolaverage.py

Modified

-99
+    pdh = ParallelDataHelper('sdpolaverage', locals())
-100
-101
+    # When dealing with MMS, process in parallel or sequential
-102
+    # disableparallel is a hidden parameter. Only for debugging purposes!
-103
+    if disableparallel:
-104
+        pdh.bypassParallelProcessing(1)
-105
+    else:
-106
+        pdh.bypassParallelProcessing(0)
-107
-108
+    # Validate input and output parameters
--
+    try:
--
+        pdh.setupIO()
--
+    except Exception as instance:
--
+        casalog.post('%s' % instance, 'ERROR')
--
+        return False
-+
+    pdh.setupIO()
-110
-111
+    # Process the input Multi-MS
-112
+    if ParallelDataHelper.isMMSAndNotServer(infile) == True and monolithic_processing == False:
-113
+        '''
-114
+        retval{'status': True,  'axis':''}         --> can run in parallel
-115
+        retval{'status': False, 'axis':'value'}    --> treat MMS as monolithic MS, set new axis for output MMS
-116
+        retval{'status': False, 'axis':''}         --> treat MMS as monolithic MS, create an output MS
-117
+        '''
-118
-119
+        retval = pdh.validateInputParams()
-130
+            pdh.override__args('createmms', True)
-131
+            pdh.override__args('monolithic_processing', True)
-132
+            separationaxis = retval['axis']
-133
+            pdh.override__args('separationaxis', retval['axis'])
-134
+            casalog.post("Will process the input MMS as a monolithic MS", 'WARN')
-135
+            casalog.post("Will create an output MMS with separation axis \'%s\'" % retval['axis'], 'WARN')
-136
-137
+        # MMS is processed in parallel
-138
+        else:
-139
+            createmms = False
--
+            try:
--
+                pdh.override__args('createmms', False)
--
+                pdh.setupCluster('sdpolaverage')
--
+                pdh.go()
--
+            except Exception as instance:
--
+                casalog.post('%s' % instance, 'ERROR')
--
+                return False
--
--
+            return True
-+
+            pdh.override__args('createmms', False)
-+
+            pdh.setupCluster('sdpolaverage')
-+
+            pdh.go()
-+
+            return
-144
-145
+    # Create an output Multi-MS
-146
+    if createmms == True:
-147
-148
+        # Check the heuristics of separationaxis and the requested transformations
-149
+        pval = pdh.validateOutputParams()
-150
+        if pval == 0:
--
+            raise Exception(
-+
+            raise RuntimeError(
-152
+                'Cannot create MMS using separationaxis=%s with some of the requested transformations.'
-153
+                    % separationaxis
-154
+            )
-155
--
+        try:
--
+            pdh.setupCluster('sdpolaverage')
--
+            pdh.go()
--
+            monolithic_processing = False
--
+        except Exception as instance:
--
+            casalog.post('%s' % instance, 'ERROR')
--
+            return False
--
--
+        return True
-+
+        pdh.setupCluster('sdpolaverage')
-+
+        pdh.go()
-+
+        monolithic_processing = False
-+
+        return
-160
-161
+    # Create a local copy of the MSTransform tool
-162
+    mtlocal = mstransformer()
-163
+    mslocal = ms()
-164
-165
+    try:
-166
+        # Gather all the parameters in a dictionary.
-167
+        config = {}
-168
-169
+        if keepflags:
-208
+            raise ValueError('Parameter tileshape must have 1 or 3 elements.')
-209
-210
+        config['tileshape'] = tileshape
-211
-212
+        if combinespws:
-213
+            casalog.post('Combine spws %s into new output spw'%spw)
-214
+            config['combinespws'] = True
-215
-216
+        # Only parse chanaverage if chanbin is valid
-217
+        if chanaverage and isinstance(chanbin, int) and chanbin <= 1:
--
+            raise Exception('Parameter chanbin must be > 1 to do channel averaging')
-+
+            raise ValueError('Parameter chanbin must be > 1 to do channel averaging')
-219
-220
+        # Validate the case of int or list chanbin
-221
+        if chanaverage and pdh.validateChanBin():
-222
+            casalog.post('Parse channel averaging parameters')
-223
+            config['chanaverage'] = True
-224
-225
+            # convert numpy types, until CAS-6493 is not fixed
-226
+            chanbin = fh.evaluateNumpyType(chanbin)
-227
+            config['chanbin'] = chanbin
-228
-252
+                config['outframe'] = outframe
-253
+            if phasecenter != '':
-254
+                config['phasecenter'] = phasecenter
-255
+            config['veltype'] = veltype
-256
+            config['preaverage'] = preaverage
-257
-258
+        # Only parse timeaverage parameters when timebin > 0s
-259
+        if timeaverage:
-260
+            tb = quanta.convert(quanta.quantity(timebin), 's')['value']
-261
+            if not tb > 0:
--
+                raise Exception("Parameter timebin must be > '0s' to do time averaging")
-+
+                raise ValueError("Parameter timebin must be > '0s' to do time averaging")
-263
-264
+        if timeaverage:
-265
+            casalog.post('Parse time averaging parameters')
-266
+            config['timeaverage'] = True
-267
+            config['timebin'] = timebin
-268
+            config['timespan'] = timespan
-269
+            config['maxuvwdistance'] = maxuvwdistance
-270
-271
+        polaverage_ = polaverage.strip()
-272
+        if polaverage_ != '':
-296
+        casalog.post('%s' % config, 'DEBUG')
-297
+        mtlocal.config(config)
-298
-299
+        # Open the MS, select the data and configure the output
-300
+        mtlocal.open()
-301
-302
+        # Run the tool
-303
+        casalog.post('Apply the transformations')
-304
+        mtlocal.run()
-305
-+
+    finally:
-307
+        mtlocal.done()
-308
--
+    except Exception as instance:
--
+        mtlocal.done()
--
+        casalog.post('%s' % instance, 'ERROR')
--
+        return False
-309
-310
+    # Update the FLAG_CMD sub-table to reflect any spw/channels selection
-311
+    # If the spw selection is by name or FLAG_CMD contains spw with names, skip the updating
-312
-313
+    if ((spw != '') and (spw != '*')) or chanaverage == True:
-314
+        isopen = False
-315
-316
+        try:
-317
+            mytb = table()
-318
+            mytb.open(outfile + '/FLAG_CMD', nomodify=False)
-391
+                                cmds[rownum] = cmd
-392
+                    if mademod:
-393
+                        casalog.post('Updating FLAG_CMD', 'INFO')
-394
+                        mytb.putcol('COMMAND', cmds)
-395
-396
+                else:
-397
+                    casalog.post('FLAG_CMD table contains spw selection by name. Will not update it!','DEBUG')
-398
-399
+            mytb.close()
-400
--
+        except Exception as instance:
-+
+        finally:
-402
+            if isopen:
-403
+                mytb.close()
-404
+            mslocal = None
-405
+            mytb = None
--
+            casalog.post("*** Error \'%s\' updating FLAG_CMD" % (instance),
--
+                         'SEVERE')
--
+            return False
-406
-407
+    mytb = None
-408
-409
+    # Write history to output MS, not the input ms.
-410
+    try:
-411
+        param_names = sdpolaverage.__code__.co_varnames[:sdpolaverage.__code__.co_argcount]
-412
+        param_vals = [eval(p) for p in param_names]
-413
+        write_history(mslocal, outfile, 'sdpolaverage', param_names,
-414
+                      param_vals, casalog)
-415
+    except Exception as instance:
-416
+        casalog.post("*** Error \'%s\' updating HISTORY" % (instance),
-417
+                     'WARN')
--
+        return False
-418
-419
+    mslocal = None
--
--
+    return True

casa6

Commits

Jira Issues

Add shortcut