Srikrishna Sekhar d190cb0804c CAS-14283: Fix bug with initial residual and deconvolve
When the initial residual was made, `deconvolve` was called with `self._niter`,
and performed actual iterations before the GUI popped up. This resulted in the
initial model image being populated, as well as other side-effects such as
cyclethreshold etc. being computed.
The net result was that the first user-defined trigger for the major cycle
would more often than not run zero or one iterations and quit, since the peak
is already close to the cyclethreshold.
This has now been fixed. CAS-14283: Fix bug with initial residual and deconvolve When the initial residual was made, `deconvolve` was called with `self._niter`,
and performed actual iterations before the GUI popped up. This resulted in the
initial model image being populated, as well as other side-effects such as
cyclethreshold etc. being computed.
The net result was that the first user-defined trigger for the major cycle
would more often than not run zero or one iteration... 15 Nov 2024 CAS-14283 Srikrishna Sekhar c299082eaa9 M Merge remote-tracking branch 'origin/master' into CAS-14283 15 Nov 2024 CAS-14283 Srikrishna Sekhar 789e09f567a CAS-14283: Include stopcode for cycleniter criterion Cycleniter is a "minor cycle exit criterion", which have their own set of
stopcodes that overlap in number with the major cycle criteria. For users of
interactive clean, this means that both cycleniter and niter (global) criteria
have stopcode 1.
In order to prevent confusion, I've assigned stopcode 11 to cycleniter. Since
this is the only minor cycle stopping criterion we are evaluating at th... 13 Nov 2024 CAS-14283 Darrell Schiebel d71ff9e3345 trigger new build [CAS-14283] 08 Nov 2024 CAS-14283 Akeem Wells 5c7ff663419 M Pull request #883: Update to use util find_spec instead of find_loader Merge in CASA/casa6 from CAS-14470 to master
* commit 'acf17965893895c92835c7cabddf517ca0821f05':
Update to use util find_spec instead of find_loader 05 Nov 2024 CAS-14470 Akeem Wells acf17965893 Update to use util find_spec instead of find_loader 25 Oct 2024 Takahiro Tsutsumi c26249c8821 M Pull request #880: Add assertTrue test at the end of test_het_mosaic_mfs_alma_listofms_CAS14350fix Merge in CASA/casa6 from CAS-14465 to master
* commit 'bc7512a0f92339aa2ee25a7909238b92e8879733':
Add assertTrue test at the end of test_het_mosaic_mfs_alma_listofms_CAS14350fix 24 Oct 2024 CAS-14465 Takahiro Tsutsumi bc7512a0f92 Add assertTrue test at the end of test_het_mosaic_mfs_alma_listofms_CAS14350fix 17 Oct 2024 Ville Suoranta 28ed41636d5 M Pull request #879: Update tests/tasks/test_task_simobserve.py (CAS-14429) Merge in CASA/casa6 from CAS-14429 to master
* commit '0f91b3e9b4011f3b383a3f5920b31c1c54b658d4':
Update tests/tasks/test_task_simobserve.py (CAS-14429) 17 Oct 2024 CAS-14429 C. Enrique Garcia Dabo 4921ac23672 M Pull request #877: CAS-14253 Merge in CASA/casa6 from CAS-14253 to master
* commit '5092c74f3e1b3523f35946fd9e67b24a7dbde8c1':
Add test cases for expected failures in gencal
Add test with the new functionality to create a caltable from ALMA antenna positions JSON file
CAS-14253: Use input JSON file to compute the ALMA antenna position corrections
CAS-14253: Describe the infile parameter for the JSON ALMA antenna p... 17 Oct 2024 CAS-14253 C. Enrique Garcia Dabo 5092c74f3e1 M Merge branch 'master' into CAS-14253 16 Oct 2024 CAS-14253 C. Enrique Garcia Dabo 727f56b56e8 M Merge commit '597480507465b5b0a800ba5dcfe13554a12b4bd2' into CAS-14253 16 Oct 2024 CAS-14253 C. Enrique Garcia Dabo 675eba3c8e1 M Merge commit '8b0120d0d2d2ecb47b0d80c076b30679aa556d70' into CAS-14253 16 Oct 2024 CAS-14253 C. Enrique Garcia Dabo ce03b1d052e M Merge commit '73c121f99c0f7a5a950101aa43852ac46365e370' into CAS-14253 16 Oct 2024 CAS-14253 Takahiro Tsutsumi ce914402cb0 M Pull request #876: CAS-14350 Merge in CASA/casa6 from CAS-14350 to master
* commit '0ef240c2282d14ed16d17ccdcc10f1f45943e765':
Add a unit test
Add a check if a parameter is a list before trying to reorder for the list-of-MS parameters. 14 Oct 2024 CAS-14350 Kazuhiko Shimada 2f7e80b18ec M Pull request #874: CAS-14417 Merge in CASA/casa6 from CAS-14417 to master
* commit '5415115a5ffd466b56ce96afce6383a48c610642':
CAS-14417: modified tests with channel selection to execute tsdimaging properly
CASA-14417: fixed the regression test of M100/SD
CAS-14417: added some tests for the interpolation parameter
CAS-14417: modified tests to change default interpolation parameter from nearest to linear 14 Oct 2024 2 Jira issuesVille Suoranta 8d65b1aa58e M Pull request #875: CAS-14416 Merge in CASA/casa6 from CAS-14416 to master
* commit '5fd67776d234f5b1bdd6ddfc8cf0194d717c1287':
Update casaviewer in build.conf
Update CasaViewer version in build.conf
Update build.conf 14 Oct 2024 CAS-14416 Ville Suoranta 5fd67776d23 Update casaviewer in build.conf 11 Oct 2024 C. Enrique Garcia Dabo e287e92a347 M Merge branch 'master' into CAS-14253 11 Oct 2024 CAS-14253 C. Enrique Garcia Dabo ff5b9a68b8b M Merge branch 'master' into CAS-14253 11 Oct 2024 CAS-14253 Akeem Wells 029970bd1f0 M Pull request #872: CAS-14457 Merge in CASA/casa6 from CAS-14457 to master
* commit 'e14d7a1ce2e2621eb4ab5d5d8d66b05975b435c8':
Add backward compatibility
Convert assertDictContainsSubset(a, b) to assertEqual(b, b | a)
Add test_tool_synthesisutils to component_to_test_map 10 Oct 2024 CAS-14457 Akeem Wells e14d7a1ce2e Add backward compatibility 08 Oct 2024 Akeem Wells 578bf5600fc Convert assertDictContainsSubset(a, b) to assertEqual(b, b | a) 08 Oct 2024 Akeem Wells 573a3f65b29 Add test_tool_synthesisutils to component_to_test_map 08 Oct 2024 Takahiro Tsutsumi 7f59542b4d4 M Pull request #871: CAS-14371 Merge in CASA/casa6 from CAS-14371 to master
* commit '754c61a43cacd511bf7b85e7053d53082f3aeb38':
Removed the numbsubms parameter setting in importasdm after Tak's fix to the setjy code.
Use ms_p to extract MS table name instead of mssel_p to avoid an issue encountered involving MMS
Added numsubms=2 to the importasdm call to bypass the error with MMS in setjy when using usescratch=False 07 Oct 2024 CAS-14371 Ville Suoranta ac417588598 M Pull request #870: Update casacore Merge in CASA/casa6 from CAS-14451 to master
* commit '9c057c10a5f8aec71b26df690072c036ec5fa2a2':
Update casacore 02 Oct 2024 CAS-14451 Sandra Castro 59748050746 M Pull request #869: CAS-14391 Merge in CASA/casa6 from CAS-14391 to master
* commit '40014047719f1b68325a80aca9a19607df4c5e5f':
Removed another instance checking for Python 2 code.
Removed casa5-related code. Added import inspect in parallel_task_helper Removed the use of default for a few regression scripts Removed the suite function from a few test scripts.
Fixed the local_vars variable inside the write history blo... 30 Sep 2024 CAS-14391 Ville Suoranta 8b0120d0d2d M Pull request #868: CAS-14441 Merge in CASA/casa6 from CAS-14441 to master
* commit '05d9d968863b51760c41918d0f09825e44df2d7c':
Escape double quotes
Refine filtering for CAS-14441 27 Sep 2024 CAS-14441 Ville Suoranta 9c057c10a5f Update casacore 27 Sep 2024 Sandra Castro 40014047719 Removed another instance checking for Python 2 code. 27 Sep 2024 Andrew McNichols 0f91b3e9b40 Update tests/tasks/test_task_simobserve.py (CAS-14429) Clean up tearDown methods that were not completely removing test files from the working directory 24 Sep 2024 CAS-14429 Ville Suoranta 05d9d968863 Escape double quotes 23 Sep 2024 Ville Suoranta d87b14bb000 Update CasaViewer version in build.conf 20 Sep 2024 Sandra Castro 754c61a43ca Removed the numbsubms parameter setting in importasdm after Tak's fix to the setjy code. 20 Sep 2024 Takahiro Tsutsumi 8cb84c48a2a M Merge branch 'master' into CAS-14371 19 Sep 2024 CAS-14371 Takahiro Tsutsumi 0a8dee7aaab Use ms_p to extract MS table name instead of mssel_p to avoid an issue encountered involving MMS 19 Sep 2024 Ville Suoranta df5270a3b6c Refine filtering for CAS-14441 18 Sep 2024 CAS-14441 Sandra Castro 8549f4ed409 Added numsubms=2 to the importasdm call to bypass the error with MMS in setjy when using usescratch=False 18 Sep 2024 Takeshi Nakazato f127ea9c33e M Pull request #865: CAS-13863 Merge in CASA/casa6 from CAS-13863 to master
* commit 'bbe7d372e537c293e32064db11eef17498ec9f4e':
CAS-13863 update unittest to be consistent with the implementation
CAS-13863 incorporate the update provided by Todd Hunter 17 Sep 2024 CAS-13863 Takeshi Nakazato 73c121f99c0 M Pull request #863: CAS-9957 Merge in CASA/casa6 from CAS-9957 to master
* commit '60c4540243eb8ce72f8f074d4fd56ccb910b3563':
refactoring
refactoring using slice functions
npol=4 is not supported
put const before type
Refactoring for consistent coding style
define weightMat as reference
renamed weightspec to weightSpec
CAS-9957 handle the case when both Wxx and Wyy is zero
Use built-in types instead of c... 17 Sep 2024 CAS-9957 Takeshi Nakazato bbe7d372e53 M Merge branch 'master' into CAS-13863 17 Sep 2024 CAS-13863 Kazuhiko Shimada 5415115a5ff CAS-14417: modified tests with channel selection to execute tsdimaging properly 16 Sep 2024 CAS-14417 Takeshi Nakazato 60c4540243e M Merge branch 'master' into CAS-9957 16 Sep 2024 CAS-9957 Ville Suoranta 4dcad261a9b Update build.conf 16 Sep 2024 smcastro 1cd5497908c M Merge branch 'master' into CAS-14391 16 Sep 2024 CAS-14391 Ville Suoranta 0c7c9f99601 M Pull request #864: Update build options in readme.md. Merge in CASA/casa6 from CAS-14434 to master
* commit 'd5ad268d9b68844013e1127f67c9b4d346763701':
Update build options in readme.md. CAS-14434 13 Sep 2024 CAS-14434 smcastro f6692b42489 M Merge branch 'master' into CAS-14391 13 Sep 2024 CAS-14391 Ville Suoranta b7d4367e3d7 M Pull request #862: CAS-14265 Merge in CASA/casa6 from CAS-14265 to master
* commit 'd34f304e22c5cbf50d9d3ec8b70f800603c85ae7':
Fix C++17 deprecations 12 Sep 2024 CAS-14265 Takeshi Nakazato a6abe864de7 M Merge branch 'master' into CAS-9957 11 Sep 2024 CAS-9957 Akeem Wells 60db5ba649d M Pull request #861: CAS-14377 Merge in CASA/casa6 from CAS-14377 to master
* commit '2e40f49fb5a2497626567752b03dc6b61ae8ec49':
Update documentation
Update docstrings and documentation for runtest, xmlrunner_to_junit and testhelper in casatestutils 10 Sep 2024 CAS-14377