Commits

Joshua Root authored 2bb42647084
dokuwiki: fix php* variants

Braces disable substitution, which means the ${php} in the variant body was evaluated when the variants are evaluated, after the main body of the portfile. It thus always had the last value set by the foreach loop. This is what the "eval subst" was fixing, but it's an antipattern because the much simpler and better performing approach is to just not use braces in the first place. Quotes can be used instead to group the variant body into a single argument.
No tags

www/dokuwiki/Portfile

Modified
15 15 companies documentation needs. It works on plain texts files \
16 16 and thus needs no database. It has a simple but powerful \
17 17 syntax which makes sure the datafiles remain readable outside \
18 18 the Wiki.
19 19
20 20 checksums rmd160 cc9383ae8e056323c32fa79a0b6dc319202ccb19 \
21 21 sha256 d6c03b9832214f89a164aabf80eb5c1e8f5b640936bb0f42c5d7c0f9fc0de3cc \
22 22 size 3693646
23 23
24 24 foreach php {php56 php70 php71 php72} {
25 - variant ${php} description "Use ${php}" {
25 + variant ${php} description "Use ${php}" "
26 26 depends_run \
27 27 port:${php} \
28 28 port:${php}-openssl
29 - }
29 + "
30 30 }
31 31
32 32 if {![variant_isset php56] && ![variant_isset php70] && ![variant_isset php71]} {
33 33 default_variants +php72
34 34 }
35 35
36 36 use_configure no
37 37
38 38 build {}
39 39

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut