C. Enrique Garcia Dabo | 178c3684549Add test cases for expected failures in gencal
Fixes partially CAS-14253 | Add test cases for expected failures in gencalFixes partially CAS-14253 | | CAS-14253 |
C. Enrique Garcia Dabo | 1b722323bf4 | Add test with the new functionality to create a caltable from ALMA antenna positions JSON fileFixes partially CAS-14253 | | CAS-14253 |
C. Enrique Garcia Dabo | b773abf0d3a | CAS-14253: Use input JSON file to compute the ALMA antenna position corrections | | CAS-14253 |
C. Enrique Garcia Dabo | 08f1f7f96cc | CAS-14253: Describe the infile parameter for the JSON ALMA antenna positions case | | CAS-14253 |
C. Enrique Garcia Dabo | 1f7b64d95dfM | Merge branch 'CAS-14235' into CAS-14253 | | 2 Jira issues |
David Mehringer | 3ca5b63d630 | doc corrections requested by akepley | | |
David Mehringer | 253db56ae74 | tweak of output data structure | | |
David Mehringer | 3006ac45e0c | change output struct from list to dict | | |
David Mehringer | c268bbb13f4 | added "caltype" to metadata | | |
David Mehringer | 5d92287e992 | fix up test | | |
David Mehringer | 75cdc73a5ac | add json.loads() to write to a file something easier for gencalto handle. Requested by Enrique. | | |
C. Enrique Garcia Dabo | e7b403d5f27M | Merge branch 'CAS-14235' into CAS-14253 | | 2 Jira issues |
David Mehringer | da4f80b3941 | minor doc updates | | |
Ville Suoranta | a24aff35f28M | Pull request #775: Update Casacore to f1c629840eMerge in CASA/casa6 from CAS-14274 to master
* commit '0ea19da0cbb2b20ba84125a4a91978e020429fdc':
Update Casacore to f1c629840e | | CAS-14274 |
David Mehringer | 8bee9ba3c37 | new doc updates | | |
David Mehringer | 9339dae883e | doc fix | | |
David Mehringer | e71238a4ce8M | Merge branch 'master' into CAS-14235 | | CAS-14235 |
 Srikrishna Sekhar | 78334a52026M | Pull request #776: CAS-14184Merge in CASA/casa6 from CAS-14184 to master
* commit '23ace523ef21f0c5a04b5bd5f527a147712e0274': (55 commits)
CAS-14184 : Fix test to account for previous change
CAS-14184 : Remove print statements in deconvolve
CAS-14184 : Fix to deconvolve return dict
CAS-14184 : Fixes to gclean tests + masking bugfix
fixed typo in json entry.
Renamed test_task_gclean to test_imagerhelpers_gclea... | | CAS-14184 |
Srikrishna Sekhar | 23ace523ef2 | CAS-14184 : Fix test to account for previous changeThe "test_mask_preserve_input_zero_mask" test in test_task_deconvolve
was failing because of the wrong stopcode. As of the previous commit the
stopcode is now over-written by the niter=0 dict, rather than what is
written by the C++ code. This has no operation impact apart from the
specific niter=0 case, and the stopcode for this test had to be changed
to reflect that. | | CAS-14184 |
Srikrishna Sekhar | a467ec080acM | Merge remote-tracking branch 'origin/master' into CAS-14184 | | CAS-14184 |
Srikrishna Sekhar | 17dcee84afc | CAS-14184 : Remove print statements in deconvolve | | CAS-14184 |
Srikrishna Sekhar | 8f601cfc309 | CAS-14184 : Fix to deconvolve return dictThe task_deconvolve return dictionary did not contain "stopDescription"
for the niter=0 case. This commit fixes that issue. | | CAS-14184 |
Srikrishna Sekhar | 9ed09e701eb | CAS-14184 : Fixes to gclean tests + masking bugfixIf a static user mask was provided in the input (e.g.,
circle[[50px,50px],10px]) the final mask-update deconvolve step was
breaking. It did not break for auto-masking or any other type of input
mask. This has been fixed by setting mask = '' in the last deconvolve
call, which still does the right thing for auto-masking etc.
Further, the default masking behaviour changed as of a few commits ago.... | | CAS-14184 |
Sandra Castro | ee54dadb225 | fixed typo in json entry. | | |
Sandra Castro | 4efe43b2c2c | Renamed test_task_gclean to test_imagerhelpers_gclean and moved it to the scripts directory.Added the new test script to the mapping json file to run automatically in Bamboo. | | |
Sandra Castro | a0a4205bd45 | Added main at the end of tests.Removed unused imports
Renamed class of test. | | |
Srikrishna Sekhar | f6b7c80f4bf | CAS-14184 : Bug fix for previous commitForgot to remove a second line that had the wrong maskname. Also removed
extraneous print statements in gclean | | CAS-14184 |
Srikrishna Sekhar | 50f6c9f8537 | CAS-14184 : Fix for mask MTMFS naming conventionThe mask for MT-MFS is called "imagename.mask" not "imagename.mask.tt0". | | CAS-14184 |
Srikrishna Sekhar | 53ab1f24ba5 | CAS-14184 : Test for partial mask in gcleanAdded a unit test to check the use case of a single channel masked while
deconvolving a cube in gclean | | CAS-14184 |
 Sandra Castro | 0a45919b4a4M | Pull request #774: CAS-13714Merge in CASA/casa6 from CAS-13714 to master
* commit '9bd7a74d61dfcdb3638178e26880df518f04c9be':
This commit is unrelated to the changes on this branch. They are changes needed for the verification tests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again some of the entries in the json file that were out of place.
Removed unused function prepinputmask.... | | CAS-13714 |
Srikrishna Sekhar | 1f3998a5ff7 | CAS-14184 : Fix for history loggingIf convergence was hit, the logger would repeatedly print out it's entire
history to the log. Issued a fix to account for that. | | CAS-14184 |
Srikrishna Sekhar | 730b65e0308 | CAS-14184 : Fix mask handling logic on startupThe mask handling used to be in the frontend, but moved it to the
backend. It now correctly accounts for a restarted state with a
previously active mask.
The logic is :
- Initial launch : If usemask='user' and mask = '' then make sure the
default mask is filled with zeros before the GUI is launched. Leave mask
untouched for all other cases
- Restart :
- If usemask='user' and mask='' :
... | | CAS-14184 |
Srikrishna Sekhar | 8efbcbc1ffd | CAS-14184 : Fix typos in automasking paramsThere were typos in the newly added automasking parameters that were
causing gclean to crash on startup. | | CAS-14184 |
Srikrishna Sekhar | a3f52b7c17d | CAS-14184 : Fixed masking paramsSome auto-multithresh parameters were missing from the _gclean input,
added those in.
The order of masking was also incorrect, the auto-mask growing was
happening _prior_ to deconvolution rather than after. This has also been
fixed. | | CAS-14184 |
Srikrishna Sekhar | 3d8bd599cb1 | CAS-14184 : More fixes to iteration control | | CAS-14184 |
Akeem Wells | 04c361bc1fb | Update component_to_test_map to add getantposalma | | |
Srikrishna Sekhar | eca97e82ad9 | CAS-14184 : Add check for user updated maskThe user can update/change the mask in between major cycles. Previously
gclean was invoking `deconvolve` to do this, but now there is an
additional function that uses `imstat` to check if the peakresidual has
changed because of a mask update in between major cycles.
This has implications on whether to continue deconvolution or not, and
therefore needs to be done before deconvolve is called. | | CAS-14184 |
Ville Suoranta | 0ea19da0cbb | Update Casacore to f1c629840e | | |
Srikrishna Sekhar | de3560ad489 | CAS-14184 : Fix peakres calculationAdded a check for masksum while calculating peakres across a cube. Only
in the case that masksum > 0 is peakres considered now.
This prevents the "bouncing" behaviour reported by Josh described below:
Iteration 1 :
field 0, chan 0, stokes 0, peakres [1.0149141550064087]
field 0, chan 1, stokes 0, peakres [5.736467361450195]
field 0, chan 2, stokes 0, peakres [4.154384136199951]
cyclethreshol... | | CAS-14184 |
Srikrishna Sekhar | 9f8146167b4 | CAS-14184 : Fixes for test failuresThere was a bug in how a non-existent mask was handled. This has now
been fixed. | | CAS-14184 |
Srikrishna Sekhar | 03739099c27 | CAS-14184 : Bugfix for niter=0 peakres calculationIf no mask was passed in for the niter=0 case, the `ImagingDict`
class set the `mask` parameter to -1 (instead of the pixel mask).
peakRes was always calcualted as `np.amax(image_pixels * mask_pixels)`
so when mask = -1 it picked the highest negative as the peakRes.
This commit fixes that bug, and has been confirmed to pass the
previously failing task_tclean tests.
Additionally, removed a che... | | CAS-14184 |
Sandra Castro | 9bd7a74d61d | This commit is unrelated to the changes on this branch. They are changes needed for the verificationtests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again
some of the entries in the json file that were out of place. | | |
Ville Suoranta | 2ad6b58ab24M | Pull request #773: CAS-14125Merge in CASA/casa6 from CAS-14125 to master
* commit '84f7fac6687c36a544699c3c4d06fe9baa4998f6':
Use c++14 standard on all platforms
Add status messages
Require C++14 on Macs | | CAS-14125 |
David Mehringer | 9715d52dea3M | Merge branch 'master' into CAS-14235 | | CAS-14235 |
Sandra Castro | dd2622d7de2 | Removed unused function prepinputmask. | | |
Sandra Castro | c6b60c4dead | Removed casa5-related code from the tests. | | |
 Takahiro Tsutsumi | 6f83e42ed2aM | Pull request #771: CAS-13705Merge in CASA/casa6 from CAS-13705 to master
* commit '9483e883e5d389032b40e1139100991582c7315e': (31 commits)
add a commnet (mostly to retrigger the Bamboo build)
Update tests for the added overwrite parameter
Fixed a typo
Minor parameter description edit
Add overwrite parameter and check when overwrite=F
Edit on error message
A minor edit on the error message
Catch if there i... | | CAS-13705 |
David Mehringer | 5e26f6348ed | add metaata to output file as python dict | | |
Ville Suoranta | 9483e883e5dM | Merge branch 'master' into CAS-13705 | | CAS-13705 |
 David Mehringer | 632b7aa2fc8M | Pull request #772: CAS-14165 create getcalmodvla taskMerge in CASA/casa6 from CAS-14165 to master
* commit 'db60838f8f784f9de5b7e8875f0da1edafda74f2': (53 commits)
use certifi to squash [SSL: CERTIFICATE_VERIFY_FAILED] issue
update declaration and summary generated by casadocs
remove renamed files
rename calmodvla -> getcalmodvla
updated task description generated by casadocs
calmod -> calmodvla name change
calmod -> calmodvla name... | | CAS-14165 |