1. casa
  2. casa6

Commits

AuthorCommitMessageCommit dateIssues
Srikrishna SekharSrikrishna Sekhar
2363e285361CAS-14283 : Allow calcres,calcpsf=False in first call If calcres=False and calcpsf=False in the first call, the first major cycle need not be run and we can go straight into deconvolution. Added the conditional statements to support this use case in _gclean.pyCAS-14283 : Allow calcres,calcpsf=False in first callIf calcres=False and calcpsf=False in the first call, the first major cycle need not be run and we can go straight into deconvolution. Added the conditional statements to support this use case in _gclean.pyCAS-14283
Srikrishna SekharSrikrishna Sekhar
de89f2e2955CAS-14283 : Add automask params to gclean.__updategclean._update accepts automasking parameters. This follows a change in casagui to add automasking parameters to the front end.CAS-14283
Darrell SchiebelDarrell Schiebel
25f6982f129the mask parameter of imstat is an LEL expression
Darrell SchiebelDarrell Schiebel
13655eefe8ffix typos [CAS-14283]CAS-14283
Srikrishna SekharSrikrishna Sekhar
ed64fec8e6dCAS-14283 : Add missing tclean/deconvolve paramsAdd the missing parameters into tclean + deconvolve. There are some exceptions, detailed below. As of this commit, the status is as follows. "allowed" but non-functional (i.e., will not throw an error if passed into run_iclean) - calcpsf - calcres - restoration not allowed (i.e., will throw an error) - outlierfile These will be fixed in future commits.CAS-14283
Darrell SchiebelDarrell Schiebel
2f1bdf9f2d3fix needed for OLD build system due to setuptools update [CAS-14283]CAS-14283
Srikrishna SekharSrikrishna Sekhar
356192c5978CAS-14283 : Add nsigma and threshold to gclean.updateThe interactive clean GUI now exposes the threshold and nsigma parameters as user-configurable. gclean.update has been updated to reflect this change, including some basic sanity checks on the user-input values.CAS-14283
Srikrishna SekharSrikrishna Sekhar
a107df5b65aCAS-14283 : Add __del__ to _gclean.pyAdded __del__ method to _gclean.py, which does the restoration step (if not already run) when the generator terminates. This allows for more graceful termination of gclean, and leaves a "finished" image on disk, rather than only the residual and model images.CAS-14283
Ville SuorantaVille Suoranta
a24aff35f28MPull request #775: Update Casacore to f1c629840eMerge in CASA/casa6 from CAS-14274 to master * commit '0ea19da0cbb2b20ba84125a4a91978e020429fdc': Update Casacore to f1c629840eCAS-14274
Srikrishna SekharDarrell SchiebelSrikrishna Sekhar
78334a52026MPull request #776: CAS-14184Merge in CASA/casa6 from CAS-14184 to master * commit '23ace523ef21f0c5a04b5bd5f527a147712e0274': (55 commits) CAS-14184 : Fix test to account for previous change CAS-14184 : Remove print statements in deconvolve CAS-14184 : Fix to deconvolve return dict CAS-14184 : Fixes to gclean tests + masking bugfix fixed typo in json entry. Renamed test_task_gclean to test_imagerhelpers_gclea...CAS-14184
Srikrishna SekharSrikrishna Sekhar
23ace523ef2CAS-14184 : Fix test to account for previous changeThe "test_mask_preserve_input_zero_mask" test in test_task_deconvolve was failing because of the wrong stopcode. As of the previous commit the stopcode is now over-written by the niter=0 dict, rather than what is written by the C++ code. This has no operation impact apart from the specific niter=0 case, and the stopcode for this test had to be changed to reflect that.CAS-14184
Srikrishna SekharSrikrishna Sekhar
a467ec080acMMerge remote-tracking branch 'origin/master' into CAS-14184CAS-14184
Srikrishna SekharSrikrishna Sekhar
17dcee84afcCAS-14184 : Remove print statements in deconvolveCAS-14184
Srikrishna SekharSrikrishna Sekhar
8f601cfc309CAS-14184 : Fix to deconvolve return dictThe task_deconvolve return dictionary did not contain "stopDescription" for the niter=0 case. This commit fixes that issue.CAS-14184
Srikrishna SekharSrikrishna Sekhar
9ed09e701ebCAS-14184 : Fixes to gclean tests + masking bugfixIf a static user mask was provided in the input (e.g., circle[[50px,50px],10px]) the final mask-update deconvolve step was breaking. It did not break for auto-masking or any other type of input mask. This has been fixed by setting mask = '' in the last deconvolve call, which still does the right thing for auto-masking etc. Further, the default masking behaviour changed as of a few commits ago....CAS-14184
Sandra CastroSandra Castro
ee54dadb225fixed typo in json entry.
Sandra CastroSandra Castro
4efe43b2c2cRenamed test_task_gclean to test_imagerhelpers_gclean and moved it to the scripts directory.Added the new test script to the mapping json file to run automatically in Bamboo.
Sandra CastroSandra Castro
a0a4205bd45Added main at the end of tests.Removed unused imports Renamed class of test.
Srikrishna SekharSrikrishna Sekhar
f6b7c80f4bfCAS-14184 : Bug fix for previous commitForgot to remove a second line that had the wrong maskname. Also removed extraneous print statements in gcleanCAS-14184
Srikrishna SekharSrikrishna Sekhar
50f6c9f8537CAS-14184 : Fix for mask MTMFS naming conventionThe mask for MT-MFS is called "imagename.mask" not "imagename.mask.tt0".CAS-14184
Srikrishna SekharSrikrishna Sekhar
53ab1f24ba5CAS-14184 : Test for partial mask in gcleanAdded a unit test to check the use case of a single channel masked while deconvolving a cube in gcleanCAS-14184
Sandra CastroVille SuorantaSandra Castro
0a45919b4a4MPull request #774: CAS-13714Merge in CASA/casa6 from CAS-13714 to master * commit '9bd7a74d61dfcdb3638178e26880df518f04c9be': This commit is unrelated to the changes on this branch. They are changes needed for the verification tests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again some of the entries in the json file that were out of place. Removed unused function prepinputmask....CAS-13714
Srikrishna SekharSrikrishna Sekhar
1f3998a5ff7CAS-14184 : Fix for history loggingIf convergence was hit, the logger would repeatedly print out it's entire history to the log. Issued a fix to account for that.CAS-14184
Srikrishna SekharSrikrishna Sekhar
730b65e0308CAS-14184 : Fix mask handling logic on startupThe mask handling used to be in the frontend, but moved it to the backend. It now correctly accounts for a restarted state with a previously active mask. The logic is : - Initial launch : If usemask='user' and mask = '' then make sure the default mask is filled with zeros before the GUI is launched. Leave mask untouched for all other cases - Restart : - If usemask='user' and mask='' : ...CAS-14184
Srikrishna SekharSrikrishna Sekhar
8efbcbc1ffdCAS-14184 : Fix typos in automasking paramsThere were typos in the newly added automasking parameters that were causing gclean to crash on startup.CAS-14184
Srikrishna SekharSrikrishna Sekhar
a3f52b7c17dCAS-14184 : Fixed masking paramsSome auto-multithresh parameters were missing from the _gclean input, added those in. The order of masking was also incorrect, the auto-mask growing was happening _prior_ to deconvolution rather than after. This has also been fixed.CAS-14184
Srikrishna SekharSrikrishna Sekhar
3d8bd599cb1CAS-14184 : More fixes to iteration controlCAS-14184
Srikrishna SekharSrikrishna Sekhar
eca97e82ad9CAS-14184 : Add check for user updated maskThe user can update/change the mask in between major cycles. Previously gclean was invoking `deconvolve` to do this, but now there is an additional function that uses `imstat` to check if the peakresidual has changed because of a mask update in between major cycles. This has implications on whether to continue deconvolution or not, and therefore needs to be done before deconvolve is called.CAS-14184
Ville SuorantaVille Suoranta
0ea19da0cbbUpdate Casacore to f1c629840e
Srikrishna SekharSrikrishna Sekhar
de3560ad489CAS-14184 : Fix peakres calculationAdded a check for masksum while calculating peakres across a cube. Only in the case that masksum > 0 is peakres considered now. This prevents the "bouncing" behaviour reported by Josh described below: Iteration 1 : field 0, chan 0, stokes 0, peakres [1.0149141550064087] field 0, chan 1, stokes 0, peakres [5.736467361450195] field 0, chan 2, stokes 0, peakres [4.154384136199951] cyclethreshol...CAS-14184
Srikrishna SekharSrikrishna Sekhar
9f8146167b4CAS-14184 : Fixes for test failuresThere was a bug in how a non-existent mask was handled. This has now been fixed.CAS-14184
Srikrishna SekharSrikrishna Sekhar
03739099c27CAS-14184 : Bugfix for niter=0 peakres calculationIf no mask was passed in for the niter=0 case, the `ImagingDict` class set the `mask` parameter to -1 (instead of the pixel mask). peakRes was always calcualted as `np.amax(image_pixels * mask_pixels)` so when mask = -1 it picked the highest negative as the peakRes. This commit fixes that bug, and has been confirmed to pass the previously failing task_tclean tests. Additionally, removed a che...CAS-14184
Sandra CastroSandra Castro
9bd7a74d61dThis commit is unrelated to the changes on this branch. They are changes needed for the verificationtests when running tests that are not in the casatasks/tests/tasks/ path. I also sorted again some of the entries in the json file that were out of place.
Ville SuorantaVille Suoranta
2ad6b58ab24MPull request #773: CAS-14125Merge in CASA/casa6 from CAS-14125 to master * commit '84f7fac6687c36a544699c3c4d06fe9baa4998f6': Use c++14 standard on all platforms Add status messages Require C++14 on MacsCAS-14125
Sandra CastroSandra Castro
dd2622d7de2Removed unused function prepinputmask.
Sandra CastroSandra Castro
c6b60c4deadRemoved casa5-related code from the tests.
Takahiro TsutsumiVille SuorantaTakahiro Tsutsumi
6f83e42ed2aMPull request #771: CAS-13705Merge in CASA/casa6 from CAS-13705 to master * commit '9483e883e5d389032b40e1139100991582c7315e': (31 commits) add a commnet (mostly to retrigger the Bamboo build) Update tests for the added overwrite parameter Fixed a typo Minor parameter description edit Add overwrite parameter and check when overwrite=F Edit on error message A minor edit on the error message Catch if there i...CAS-13705
Ville SuorantaVille Suoranta
9483e883e5dMMerge branch 'master' into CAS-13705CAS-13705
David MehringerVille SuorantaDavid Mehringer
632b7aa2fc8MPull request #772: CAS-14165 create getcalmodvla taskMerge in CASA/casa6 from CAS-14165 to master * commit 'db60838f8f784f9de5b7e8875f0da1edafda74f2': (53 commits) use certifi to squash [SSL: CERTIFICATE_VERIFY_FAILED] issue update declaration and summary generated by casadocs remove renamed files rename calmodvla -> getcalmodvla updated task description generated by casadocs calmod -> calmodvla name change calmod -> calmodvla name...CAS-14165
Ville SuorantaVille Suoranta
84f7fac6687MMerge branch 'master' into CAS-14125CAS-14125
George MoellenbrockVille SuorantaGeorge Moellenbrock
326629aeabfMPull request #770: CAS-14219Merge in CASA/casa6 from CAS-14219 to master * commit '7334dd27c6038c278b21b700840c940e8f564478': For CAS-14219, explicitly import measures (me) tool so it works in modular casa6; added revision description For CAS-14219, some further minor refinements to the script and tests. For CAS-14219, update formation of IGS filename to match the new CDDIS convention (including for rapid product f...3 Jira issues
Takahiro TsutsumiTakahiro Tsutsumi
b6a3f36c9dcMMerge branch 'master' into CAS-13705CAS-13705
David MehringerDavid Mehringer
db60838f8f7use certifi to squash [SSL: CERTIFICATE_VERIFY_FAILED] issue
George MoellenbrockGeorge Moellenbrock
7334dd27c60MMerge branch 'master' into CAS-14219CAS-14219
Takeshi NakazatoVille SuorantaTakeshi Nakazato
8af308c8fe8MPull request #769: CAS-13087Merge in CASA/casa6 from CAS-13087 to master * commit 'e8d234d102b04e2a124f23c0e0af820bf72f978e': (51 commits) CAS-13087 cleanup tentative code Minor bug fix on test code CAS-13087 fix problem in ms conformance tests CAS-13087 more refactoring CAS-13087 additional modofication for merging master into this branch Revert "Merge branch 'master' into CAS-13087" Merge branch 'master' ...CAS-13087
Srikrishna SekharSrikrishna Sekhar
01c05a91e50CAS-14184 : Fix cyclefactor param checkAny value > 0 is valid for cyclefactor, but previously the parameter check would insist that cyclefactor > 1.CAS-14184
Ville SuorantaSandra CastroVille Suoranta
07df7e213c0MPull request #768: Do not filter warnings in task_plotbandpass.pyMerge in CASA/casa6 from CAS-14224 to master * commit '04f05a69f407fc5014c2c7fd310a91f4de061672': Do not filter warnings in task_plotbandpass.pyCAS-14224
Srikrishna SekharSandra CastroSrikrishna Sekhar
643fe56a886MPull request #767: CAS-13791Merge in CASA/casa6 from CAS-13791 to master * commit '0b3b01d988822e881a47dbb8a9138d5622ebfae6': CAS-13791 : Modified tests to have gain=0.2. This reduces variability across build systems to below the standard tolerance threshold. Enabled the test for Mac too. CAS-13791 : edited the ver test func for asp CAS-13791: Set 'fusedthreshold = -1' to allow AspClean never switches to Hogbom. T...3 Jira issues
Takahiro TsutsumiTakahiro Tsutsumi
72da40aa9e5add a commnet (mostly to retrigger the Bamboo build)
Takahiro TsutsumiTakahiro Tsutsumi
9335d9ea35cUpdate tests for the added overwrite parameter

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut